feat(): Begin bedrock support #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incorrect for what version ? Item IDs are not static on bedrock |
|
Ohhhh I’m sorry I thought they were just set incorrectly that’s my bad. |
|
To implement items for bedrock there will first need to be a PR to prismarine-registry to load the items. Since most of the functions in prismarine-item fetch data from the NBT and since there's probably naming differences in the NBT data, it may also make sense to have a separate Item class for bedrock to keep things clean (anvil implementation can probably be kept as is with some feature flags). |
|
Alright thank you for the clarification, I saw in your post that that prismarine-registry bedrock support was needed but I didn’t understand why until now. |
|
what is the status of this ? |
|
we merged #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three issues with this PR that I know of atm:
spawnEggMobNamegetter will not work correctly because the spawn egg display name isn't stored in the nbt and we can't rely on the inaccurate data for the spawn egg name.features.jsonminecraft-data#667Hopefully this PR can help knock off another thing in this list.